Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Duplicated code in butonMarkup #5626

Merged
merged 1 commit into from

3 participants

@stforek

Hi.
I found duplicated code in buttonMarkup. Title is set twice for element when iconpos option is set.

@jaspermdegroot
Collaborator

@stforek

Good catch. Thanks!

@gabrielschulhof
Collaborator

The performance impact is negligible, but, of course, we should still remove it.

@jaspermdegroot jaspermdegroot merged commit 7faa9ef into jquery:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 11, 2013
  1. @stforek
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 4 deletions.
  1. +0 −4 js/jquery.mobile.buttonMarkup.js
View
4 js/jquery.mobile.buttonMarkup.js
@@ -124,10 +124,6 @@ $.fn.buttonMarkup = function( options ) {
}
}
- if ( o.iconpos && o.iconpos === "notext" && !el.attr( "title" ) ) {
- el.attr( "title", el.getEncodedText() );
- }
-
if ( buttonElements ) {
el.removeClass( buttonElements.bcls || "" );
}
Something went wrong with that request. Please try again.