Controlgroup fixes #5651

Merged
merged 1 commit into from Mar 6, 2013

Projects

None yet

2 participants

@stforek
Contributor
stforek commented Feb 18, 2013

Hi.
I found that refresh was called twice when creating controlgroup widget. First from method _setType() and then from _init(). I used _initialRefresh property to determine if options are set when widget is created. I've checked that changing type with $().controlgroup('option', 'type', 'vertical') still works :) There should probably be test added.
I also added some small performance fixes:

  • removed ui object
  • create legend wrapper only when it is needed
@gabrielschulhof gabrielschulhof merged commit 2138a09 into jquery:master Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment