Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Demos: fixed inactive Loader demo #5745

Closed
wants to merge 1 commit into from

2 participants

@jakeboone02

JavaScript for Loader options demo was under the <head> tag, which prevented it from activating when the page was AJAX-loaded. Relevant script tag has been moved to the data-role="page" element.

See working version from 1.2 docs here.

@jakeboone02 jakeboone02 Demos: fixed inactive Loader demo
JavaScript for Loader options demo was under the HEAD tag, which prevented it from activating when the page was AJAX-loaded. Relevant script tag has been moved to the data-role="page" element.
53ff5bf
@jaspermdegroot
Collaborator

@jakeboone02

Thanks for the PR. Actually the script needs to be in the head to make the "view source" utility work. I fixed the issue by setting data-role="false" on the link to the loader widget page (496c55e). Thanks for pointing us at the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 9, 2013
  1. @jakeboone02

    Demos: fixed inactive Loader demo

    jakeboone02 authored
    JavaScript for Loader options demo was under the HEAD tag, which prevented it from activating when the page was AJAX-loaded. Relevant script tag has been moved to the data-role="page" element.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 3 deletions.
  1. +4 −3 demos/widgets/loader/index.php
View
7 demos/widgets/loader/index.php
@@ -11,6 +11,10 @@
<script src="../../../js/jquery.js"></script>
<script src="../../_assets/js/"></script>
<script src="../../../js/"></script>
+</head>
+<body>
+<div data-role="page" class="jqm-demos" data-quicklinks="true">
+
<script>
$(document).on("click", ".show-page-loading-msg", function() {
var $this = $( this ),
@@ -31,9 +35,6 @@
$.mobile.loading( 'hide' );
});
</script>
-</head>
-<body>
-<div data-role="page" class="jqm-demos" data-quicklinks="true">
<div data-role="header" class="jqm-header">
<h1 class="jqm-logo"><a href="../../../"><img src="../../_assets/img/jquery-logo.png" alt="jQuery Mobile Framework"></a></h1>
Something went wrong with that request. Please try again.