table refresh method and unit tests.
Examples here: table column-toggle and table reflow-mode.
I hope I did not mix anything up manually copy&pasting between PCs (can't commit from my test environment...)
"Tables": added refresh method. Fixes #5570
Thanks a lot for the PR!
We have to see why PhantomJS times out on the test when we review this.
Can you sign the CLA please?
I had problems on the last two async tests = "column-toggle-refresh" and "is popup-visible-when-clicked". Once I switched order (first column-toggle, then popup-visible) the tests passed on Firefox and Chrome. Checking CLA now
cleaned up code
add missing start() tag
add the other two start() tags
Merge remote-tracking branch 'upstream/master' into table-refresh
my last attempt with relocating start()
@frequent I tried to merge locally to test but there are too many merge conflicts. Could you merge it and push the merge commit on that branch?
@gseguin: ok. will try tonight
updated table-refresh to new version
Sample page column-toggle here, reflow here. Unit tests passing on my local machine.
Has this problem been resolved yet?? The sample pages worked fine for me, but when it will be available to everybody else?
@arschmitz @frequent - Can we still use this for the new refresh method for 1.4 or should we close this PR?
@uGoMobi - I can make a new PR, kept all files of the 1.4. version. So up to you.
Closing this PR because we have to make the table widget modes proper widget extensions first. Let's work on a new PR after that. Thanks!
@uGoMobi : ok. Let's talk on IRC on how this should look