Skip to content

"Tables": added refresh method. Fixes #5570 - Dynamically Adding Rows to Reflow Table Results in Unformatted New Rows #5791

Closed
wants to merge 8 commits into from

4 participants

@frequent

@uGoMobi, @Toddparker

table refresh method and unit tests.

Examples here: table column-toggle and table reflow-mode.

I hope I did not mix anything up manually copy&pasting between PCs (can't commit from my test environment...)

@jaspermdegroot
jQuery Foundation member

@frequent

Thanks a lot for the PR!
We have to see why PhantomJS times out on the test when we review this.
Can you sign the CLA please?

@frequent

@uGoMobi

I had problems on the last two async tests = "column-toggle-refresh" and "is popup-visible-when-clicked". Once I switched order (first column-toggle, then popup-visible) the tests passed on Firefox and Chrome. Checking CLA now

@gseguin
jQuery Foundation member
gseguin commented Mar 28, 2013

@frequent I tried to merge locally to test but there are too many merge conflicts. Could you merge it and push the merge commit on that branch?

@frequent

@gseguin: ok. will try tonight

frequent added some commits Mar 29, 2013
@frequent frequent Merge remote-tracking branch 'upstream/master' into table-refresh
Conflicts:
	js/widgets/table.columntoggle.js
	js/widgets/table.js
	js/widgets/table.reflow.js
	tests/unit/table/index.html
269abd7
@frequent frequent updated table-refresh to new version db21f7f
@frequent

Sample page column-toggle here, reflow here. Unit tests passing on my local machine.

@FernandoFigueroa

Has this problem been resolved yet?? The sample pages worked fine for me, but when it will be available to everybody else?

@jaspermdegroot
jQuery Foundation member

@arschmitz @frequent - Can we still use this for the new refresh method for 1.4 or should we close this PR?

@frequent
frequent commented Apr 4, 2013

@uGoMobi - I can make a new PR, kept all files of the 1.4. version. So up to you.

@jaspermdegroot
jQuery Foundation member

Closing this PR because we have to make the table widget modes proper widget extensions first. Let's work on a new PR after that. Thanks!

Ticket: #5856

@frequent

@uGoMobi : ok. Let's talk on IRC on how this should look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.