Active state logic #5837

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
Member

jaspermdegroot commented Apr 1, 2013

In navigation we prevent the active state being applied to button-style links with href="#" and in the navbar widget we have code to make that work again.

This causes all kind of issues with the navbar. See #1181 and #5707 which have been fixed with a workaround.

Besides this there have been a few feature requests for making those buttons getting the active state. See #5009 and #4469. This was just partly fixed by #5337.

Member

jaspermdegroot commented Apr 1, 2013

I only tested navigation and navbar. The custom selects tests fail. Will look into that first.

Member

jaspermdegroot commented Apr 24, 2013

Going to give this another look when we work on the navbar widget for 1.4. Closing this PR but keeping the branch alive.

jaspermdegroot deleted the active-state-fix branch Jan 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment