Navigation: Preserves hash parameters so a page can be bookmarked. #5913

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

jlinse commented Apr 20, 2013

Fixes #5230 - Hash parameters get stripped from the url when used in an anchor

It's a small 2 line fix to preserve hash parameters so a page can be bookmarked or reloaded.

James Linse added some commits Apr 19, 2013

James Linse
Navigation: Preserves hash parameters so a page can be reloaded or bo…
…okmarked.


Fixes #5230 - Hash parameters get stripped from the url when used in an
anchor
James Linse
Navigation: Preserves hash parameters so a page can be reloaded or bo…
…okmarked

Addresses test failures with my last commit.  Now ensures url does not
already contain parameters before saving and possibly duplicating them.
Owner

arschmitz commented Aug 6, 2013

There are many test failures on this commit and it would also be a breaking change for some apps im closing this PR and we will be looking at the handling of hash params in 1.5

@arschmitz arschmitz closed this Aug 6, 2013

jlinse commented Aug 7, 2013

Please note that the test failures were fixed with my last commit d1cd1d6. Should I resubmit a pull request with that version? I just assumed this ticket would update with my later commit since it's in my above added commits.

Owner

arschmitz commented Aug 7, 2013

@jlinse im sorry but this is something we have already decided not to make any changes regarding query params in the hash this would be a breaking change to some apps because this has never been supported. Also starting with we decided that we will not strip the params however they will be considered part of the ID because these are perfectly valid characters for an id so if you have a link of #foo?bar=baz this will link to the page with ID #foo?bar=baz no #foo as it is now or this change would make it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment