New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3803 taphold not to emit tap event option #5983

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@jtblin

jtblin commented May 9, 2013

As explained in the previous PR discussion, there is an issue with how the option has been implemented where it will be bypassed and the taphold will not emit a tap when the option is set to true and if option is set to false, then tap will never be triggered which would be a bigger issue.
This PR also fixes an edge case when the taphold event is bound to a link, a mouseup event will still be triggered by propagation and will lead to the link being opened after the taphold is triggered. This is avoided by using event.stopPropagation() in case of taphold.

Thanks.
-Jerome

@arschmitz arschmitz closed this in 49bb033 May 9, 2013

gabrielschulhof added a commit that referenced this pull request Jun 13, 2014

Events: Fixes the problem that touchend events were stopped
(preventing vmouseup-s) if taphold is set to prevent a following tap event

This refines the modifications made in gh-5983.

Closes gh-6719
Fixes gh-7494
Re gh-5983

gabrielschulhof added a commit that referenced this pull request Jun 13, 2014

Events: Fixes the problem that touchend events were stopped
(preventing vmouseup-s) if taphold is set to prevent a following tap event

This refines the modifications made in gh-5983.

(cherry picked from commit f95bec6)

Closes gh-6719
Fixes gh-7494
Re gh-5983

agcolom added a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014

Events: Fixes the problem that touchend events were stopped
(preventing vmouseup-s) if taphold is set to prevent a following tap event

This refines the modifications made in gh-5983.

Closes gh-6719
Fixes gh-7494
Re gh-5983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment