This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Merge mobile-base branch #6133
Merged
Merge mobile-base branch #6133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mobile-base Conflicts: js/widgets/page.js
| } | ||
| }); | ||
|
|
||
| $.mobile.widget = $.Widget; |
There was a problem hiding this comment.
Is this for backwards compatibility? Might justify a line comment.
There was a problem hiding this comment.
Yes it's for back compat meant to add a todo to remove in 1.5
|
PS: The title of this PR is weird and doesn't contain any useful information. Usually useful to reference the ticket again, or at least have that in the description. |
|
You should consider doing rebasing on branches like this, avoiding a lot of merge commits. That makes it easier to keep track of changes, since your git history doesn't get riddled with merge commits. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge mobile-base branch which removes the mobile base widget in favor of extending $.Widget