New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogrow: calculated height contains border height #6180

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jhogervorst
Contributor

jhogervorst commented Jul 16, 2013

Fixes #6178

Autogrow: calculated height contains border height. Fixes #6178 - tex…
…tinput: height not correctly calculated due to box-sizing
@jhogervorst

This comment has been minimized.

Show comment
Hide comment
@jhogervorst

jhogervorst Aug 4, 2013

Contributor

Did someone take a look at this PR yet? If it's approved I make PRs for #6179 and #5688 as well.

Contributor

jhogervorst commented Aug 4, 2013

Did someone take a look at this PR yet? If it's approved I make PRs for #6179 and #5688 as well.

@arschmitz arschmitz closed this in 48139f8 Aug 6, 2013

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Aug 6, 2013

Member

@jhogervorst Thanks for the pr there were conflicts that prevented an automatic merge so i just manually applied changes thanks for the PR!

Member

arschmitz commented Aug 6, 2013

@jhogervorst Thanks for the pr there were conflicts that prevented an automatic merge so i just manually applied changes thanks for the PR!

@jhogervorst jhogervorst deleted the jhogervorst:issue-6178 branch Aug 6, 2013

@jhogervorst

This comment has been minimized.

Show comment
Hide comment
@jhogervorst

jhogervorst Aug 6, 2013

Contributor

@arschmitz Thanks! Could I've prevented those conflicts from happening?

Contributor

jhogervorst commented Aug 6, 2013

@arschmitz Thanks! Could I've prevented those conflicts from happening?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Aug 6, 2013

Member

It was because we made changes since then. You could have fixed them and updated the PR but in the intrest of time and since the change was simple i thought it best to just manually apply these.

Member

arschmitz commented Aug 6, 2013

It was because we made changes since then. You could have fixed them and updated the PR but in the intrest of time and since the change was simple i thought it best to just manually apply these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment