New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider: Remove optionDemultiplexer. #6274

Merged
merged 3 commits into from Aug 7, 2013

Conversation

Projects
None yet
3 participants
@allsteady
Contributor

allsteady commented Aug 2, 2013

Hi all ~

I removed the optionDemultiplexer from Slider widget.

  • Tests : The code has been tested on several jQM widgets using qunit.js.
  • Modified code is followed the jQuery Core Style guide.
  • Scope : Performance improvement.

If there are any problems or mistakes on that PR, please let me know. Thanks in advance.

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Aug 3, 2013

Member

@allsteady Thanks for the pull request. It looks like it's not passing the linting. Could you fix the lints and update the PR?

Member

gseguin commented Aug 3, 2013

@allsteady Thanks for the pull request. It looks like it's not passing the linting. Could you fix the lints and update the PR?

@allsteady

This comment has been minimized.

Show comment
Hide comment
@allsteady

allsteady Aug 5, 2013

Contributor

I modified the lint and removed the optionDemultiplexer from Rangeslider widget.
If there are any problems or mistakes on that PR, please let me know. Thanks in advance.

Contributor

allsteady commented Aug 5, 2013

I modified the lint and removed the optionDemultiplexer from Rangeslider widget.
If there are any problems or mistakes on that PR, please let me know. Thanks in advance.

arschmitz added a commit that referenced this pull request Aug 7, 2013

Merge pull request #6274 from allsteady/master
Slider: Remove optionDemultiplexer.

@arschmitz arschmitz merged commit 616a139 into jquery:master Aug 7, 2013

1 check failed

default The Travis CI build failed
Details

gabrielschulhof added a commit that referenced this pull request Aug 13, 2013

Collapsible: Make contentTheme an inheritable option. Fixes #6274 - C…
…ollapsible set: Dynamically added collapsible doesn't get content theme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment