jquery.mobile.tabele.reflow.js: removed the display: table-row-group; css. Fixes 6583. This display property causes assistive technology like VoiceOver to no longer detect the table as a table. #6584

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@dylanb

I apologize in advance for this pull request because I do not have Safari <= 5 and am therefore not able to reproduce bug 5380 - which this code was supposed to fix. However, the fix for 5380 is invalid because it directly causes the issue reported in 6583 in a lot of different browser and AT combinations.

@arschmitz
jQuery Foundation member

i think we are good to land this

@jaspermdegroot
jQuery Foundation member

@arschmitz

Let's pull it in a branch and test #5380 (comment)

@gabrielschulhof

OK, so it looks like we need to fix #5380 differently than by the fix we currently have in place, because the current fix breaks things in a lot of browsers. Thus, applying this patch and re-opening #5380 may be the way to go.

@arschmitz
jQuery Foundation member

👍

@gabrielschulhof gabrielschulhof added a commit that closed this pull request May 30, 2014
@dylanb dylanb Table: remove reflow CSS hack for Safari <= 5
It causes problems with assistive technology not being able to detect tables.

This effectively reverts bafa5d9, thus
removing the fix for gh-5380.

Closes gh-6584
Fixes gh-6583
Re gh-5380
71c823e
@gabrielschulhof gabrielschulhof added a commit that referenced this pull request May 30, 2014
@dylanb dylanb Table: remove reflow CSS hack for Safari <= 5
It causes problems with assistive technology not being able to detect tables.

This effectively reverts bafa5d9, thus
removing the fix for gh-5380.

(cherry picked from commit 71c823e)

Closes gh-6584
Fixes gh-6583
Re gh-5380
0ec40a4
@dylanb

Is this problem totally fixed now or are you still looking for a solution for reflowable tables that are accessible? I have two solutions one that I have tried before and one that is ore elegant that I have not fully tested but if you are looking for a solution, I could try to test and implement.

@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
@dylanb dylanb Table: remove reflow CSS hack for Safari <= 5
It causes problems with assistive technology not being able to detect tables.

This effectively reverts bafa5d9, thus
removing the fix for gh-5380.

Closes gh-6584
Fixes gh-6583
Re gh-5380
4f87675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment