Cached jquery window #6751

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@stforek
Contributor

stforek commented Nov 20, 2013

It turns out that $(window) is still used in some places in code. This small commit fixes them.

stforek added some commits Nov 20, 2013

Orientationchange: use cached jquery window
Panel: use cached jquery window
Loader: chain jquery window
Core: use cached jquery document
Vmouse: use cached jquery document
Touch: use cached jquery document
Navbar: use widget.document
@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Nov 21, 2013

This module can be used without the rest of jQuery mobile it is stand alone so it cant rely on $.mobile.window

This module can be used without the rest of jQuery mobile it is stand alone so it cant rely on $.mobile.window

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Nov 21, 2013

this is a stand alone module the does not depend on the rest of mobile there for this cannot rely on $.mobile.documemt

this is a stand alone module the does not depend on the rest of mobile there for this cannot rely on $.mobile.documemt

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Nov 21, 2013

this is a stand alone module the does not depend on the rest of mobile there for this cannot rely on $.mobile.documemt

this is a stand alone module the does not depend on the rest of mobile there for this cannot rely on $.mobile.documemt

@Ruffio

This comment has been minimized.

Show comment
Hide comment
@Ruffio

Ruffio May 30, 2014

Should this PR be closed (and not merged) as it can't be accepted or what what would it take to merge this PR?

Ruffio commented May 30, 2014

Should this PR be closed (and not merged) as it can't be accepted or what what would it take to merge this PR?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 5, 2014

Member

@Ruffio - If @stforek updates the PR based on the first feedback we can review it again.

Member

jaspermdegroot commented Jun 5, 2014

@Ruffio - If @stforek updates the PR based on the first feedback we can review it again.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Jul 31, 2014

Member

The changes in this pr look good now but we will have to rebase and test it since its so old.

Member

arschmitz commented Jul 31, 2014

The changes in this pr look good now but we will have to rebase and test it since its so old.

@arschmitz arschmitz self-assigned this Dec 23, 2014

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 23, 2014

Member

Bumping this to take care of myself

Member

arschmitz commented Dec 23, 2014

Bumping this to take care of myself

@arschmitz arschmitz closed this in 8cdc1b0 May 28, 2015

kapilgarg1996 added a commit to kapilgarg1996/jquery-mobile that referenced this pull request Jun 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment