Allow text selection in INPUTs and TEXTAREAs. #6819

Closed
wants to merge 1 commit into from

3 participants

@WebVeteran

No description provided.

@arschmitz
jQuery Foundation member

Thank you for this contribution can you please sign our CLA at http://contribute.jquery.org/CLA/ and please full describe the issue this PR fixes with a reduced test case reproducing the problem

@WebVeteran

Hi Alexander, the issue fixes a problem of the user not being able to select text in an input or textarea of a swipe-panel enabled page. Test case is in the new pull request: WebVeteran@9e0382c

@arschmitz
jQuery Foundation member

@WebVeteran in the future can you please update your PR instead of opening a new one makes it better to keep everything together.

@arschmitz arschmitz closed this Dec 31, 2013
@arschmitz
jQuery Foundation member

sorry misunderstood reopening but there was another misunderstanding when i asked for a test page i did not mean to modify the demos please read our contributing guidelines https://github.com/jquery/jquery-mobile/blob/master/CONTRIBUTING.md and create a jsbin test page demonstrating the issue and describing it fully. also please keep all changes related to a single issue in one PR

@arschmitz arschmitz reopened this Dec 31, 2013
@WebVeteran

Sorry for being such a noob at contributing. Here is a test page showing the issue: http://jsbin.com/IFolanOW/66
This pull requests changes the demo code's CSS to allow text selection - even on panel swipe pages: http://jsbin.com/icayuRo/1

@arschmitz
jQuery Foundation member

thanks ill land this shortly!

@arschmitz arschmitz self-assigned this Feb 6, 2014
@Ruffio

Is this PR ready to be landed or what is the reason for not being closed?

@arschmitz
jQuery Foundation member

@Ruffio This will me in 1.4.3 it just has not been pulled to master yet.

@arschmitz arschmitz closed this in 44f503d Jun 2, 2014
@arschmitz arschmitz added a commit that referenced this pull request Jun 3, 2014
@WebVeteran WebVeteran Demos: Allow text selection in INPUTs and TEXTAREAs.
Closes gh-6819

(cherry picked from commit 44f503d)
a253474
@agcolom agcolom added a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014
@WebVeteran WebVeteran Demos: Allow text selection in INPUTs and TEXTAREAs.
Closes gh-6819
a9fbb94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment