New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text selection in INPUTs and TEXTAREAs. #6819

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@WebVeteran
Contributor

WebVeteran commented Dec 20, 2013

No description provided.

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 23, 2013

Member

Thank you for this contribution can you please sign our CLA at http://contribute.jquery.org/CLA/ and please full describe the issue this PR fixes with a reduced test case reproducing the problem

Member

arschmitz commented Dec 23, 2013

Thank you for this contribution can you please sign our CLA at http://contribute.jquery.org/CLA/ and please full describe the issue this PR fixes with a reduced test case reproducing the problem

@WebVeteran

This comment has been minimized.

Show comment
Hide comment
@WebVeteran

WebVeteran Dec 23, 2013

Contributor

Hi Alexander, the issue fixes a problem of the user not being able to select text in an input or textarea of a swipe-panel enabled page. Test case is in the new pull request: WebVeteran@9e0382c

Contributor

WebVeteran commented Dec 23, 2013

Hi Alexander, the issue fixes a problem of the user not being able to select text in an input or textarea of a swipe-panel enabled page. Test case is in the new pull request: WebVeteran@9e0382c

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 31, 2013

Member

@WebVeteran in the future can you please update your PR instead of opening a new one makes it better to keep everything together.

Member

arschmitz commented Dec 31, 2013

@WebVeteran in the future can you please update your PR instead of opening a new one makes it better to keep everything together.

@arschmitz arschmitz closed this Dec 31, 2013

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Dec 31, 2013

Member

sorry misunderstood reopening but there was another misunderstanding when i asked for a test page i did not mean to modify the demos please read our contributing guidelines https://github.com/jquery/jquery-mobile/blob/master/CONTRIBUTING.md and create a jsbin test page demonstrating the issue and describing it fully. also please keep all changes related to a single issue in one PR

Member

arschmitz commented Dec 31, 2013

sorry misunderstood reopening but there was another misunderstanding when i asked for a test page i did not mean to modify the demos please read our contributing guidelines https://github.com/jquery/jquery-mobile/blob/master/CONTRIBUTING.md and create a jsbin test page demonstrating the issue and describing it fully. also please keep all changes related to a single issue in one PR

@arschmitz arschmitz reopened this Dec 31, 2013

@WebVeteran

This comment has been minimized.

Show comment
Hide comment
@WebVeteran

WebVeteran Jan 7, 2014

Contributor

Sorry for being such a noob at contributing. Here is a test page showing the issue: http://jsbin.com/IFolanOW/66
This pull requests changes the demo code's CSS to allow text selection - even on panel swipe pages: http://jsbin.com/icayuRo/1

Contributor

WebVeteran commented Jan 7, 2014

Sorry for being such a noob at contributing. Here is a test page showing the issue: http://jsbin.com/IFolanOW/66
This pull requests changes the demo code's CSS to allow text selection - even on panel swipe pages: http://jsbin.com/icayuRo/1

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz Feb 6, 2014

Member

thanks ill land this shortly!

Member

arschmitz commented Feb 6, 2014

thanks ill land this shortly!

@arschmitz arschmitz self-assigned this Feb 6, 2014

@Ruffio

This comment has been minimized.

Show comment
Hide comment
@Ruffio

Ruffio May 30, 2014

Is this PR ready to be landed or what is the reason for not being closed?

Ruffio commented May 30, 2014

Is this PR ready to be landed or what is the reason for not being closed?

@arschmitz

This comment has been minimized.

Show comment
Hide comment
@arschmitz

arschmitz May 30, 2014

Member

@Ruffio This will me in 1.4.3 it just has not been pulled to master yet.

Member

arschmitz commented May 30, 2014

@Ruffio This will me in 1.4.3 it just has not been pulled to master yet.

@arschmitz arschmitz closed this in 44f503d Jun 2, 2014

arschmitz added a commit that referenced this pull request Jun 3, 2014

agcolom added a commit to agcolom/jquery-mobile that referenced this pull request Nov 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment