Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Demos: highlight is now correctly removed on cancelation. Fixed #6892 - ... #6893

Closed
wants to merge 1 commit into from

5 participants

boehle Ghislain Seguin Alexander Schmitz Coveralls Gabriel "_|Nix|_" Schulhof
boehle

...Demos - Swipe to delete list item | Highlight isn't correctly removed

Highlight is now correctly removed, if you cancel the deletion of a listitem in swipe to delete demo.

Tests ran fine:

2329 assertions passed (1027483ms)

Done, without errors.

Ghislain Seguin
Owner

@boehle, Thanks for your contribution! It looks like you haven't signed our CLA. Could you do so at: http://contribute.jquery.org/CLA/ ? Thank you.

boehle

@gseguin Done.

Ghislain Seguin
Owner

CLA signed.

Alexander Schmitz
Owner

this looks good just need you to update your commit message to follow our new commit message guidelines http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines

boehle boehle Demos: highlight is now correctly removed on cancelation
In swipe to delete demo, the highlight is properly removed from the selected list item on cancelation of the deletion.

Fixes #6892
5ebafde
Coveralls

Coverage Status

Coverage remained the same when pulling 5ebafde on boehle:issue-6892 into 09832f3 on jquery:master.

boehle

@arschmitz I updated the commit message according to the new guidelines.

Alexander Schmitz
Owner

@boehle thanks ill merge it later today

Alexander Schmitz arschmitz self-assigned this
Alexander Schmitz arschmitz removed their assignment
Gabriel "_|Nix|_" Schulhof gabrielschulhof closed this pull request from a commit
boehle boehle Demos: highlight is now correctly removed on cancelation
In swipe to delete demo, the highlight is properly removed from the selected
list item on cancelation of the deletion.

Closes gh-6893
Fixes gh-6892
b2059ea
Gabriel "_|Nix|_" Schulhof gabrielschulhof referenced this pull request from a commit
boehle boehle Demos: highlight is now correctly removed on cancelation
In swipe to delete demo, the highlight is properly removed from the selected
list item on cancelation of the deletion.

Closes gh-6893
Fixes gh-6892
eff6cef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 22, 2014
  1. boehle

    Demos: highlight is now correctly removed on cancelation

    boehle authored
    In swipe to delete demo, the highlight is properly removed from the selected list item on cancelation of the deletion.
    
    Fixes #6892
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  demos/swipe-list/index.php
2  demos/swipe-list/index.php
View
@@ -75,7 +75,7 @@ function confirmAndDelete( listitem, transition ) {
});
// Remove active state and unbind when the cancel button is clicked
$( "#confirm #cancel" ).on( "click", function() {
- listitem.removeClass( "ui-btn-active" );
+ listitem.children( ".ui-btn" ).removeClass( "ui-btn-active" );
$( "#confirm #yes" ).off();
});
}
Something went wrong with that request. Please try again.