Page container: the load method now correctly returns a promise #6901

Closed
wants to merge 4 commits into
from

Projects

None yet

5 participants

@marcuskrahl
Contributor

The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes #6900

mk747gx Page container: the load method now returns a promise to comply with …
…the docs. Fixed #6900. pagecontainer("load") does not return promise
ed81cf7
@arschmitz
Member

@mk747gx it looks like you have not signed our cla can you please sign the CLA at http://contribute.jquery.org/CLA/ you will also find other useful information about contributing in general at http://contribute.jquery.org/ Let us know once you have signed and and then we can take a look at this.

@marcuskrahl
Contributor

@arschmitz I signed the CLA as requested

@arschmitz
Member

This fix looks good just one last thing is the commit message needs to be updated to our new commit message guidelines http://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines

@marcuskrahl
Contributor

I changed the commit message. Hopefully it now fulfills the commit guidelines (if not just tell me what I missed). I initially followed CONTRIBUTING.md which seems to have different rules than the link you provided. So maybe CONTRIBUTING.md needs an update.

@scottgonzalez
Member

@mk747gx I'm in the middle of updating CONTRIBUTING.md for all projects. This will be fixed within a few days. Sorry for the confusion.

@arschmitz
Member

@mk747gx can you please change your git config to have your real name and email matching what you signed the CLA with after that i can take a look at getting this merged

marcuskrahl added some commits Jan 8, 2014
@marcuskrahl marcuskrahl Page container: the load method now correctly returns a promise #6901
The API docs for version 1.4.0 state that the load method of the pagecontainer widget returns a promise. This commit adds this behaviour to the widget to comply with the docs

Fixes #6900
afabafa
@marcuskrahl marcuskrahl Merge branch 'master' of https://github.com/jquery/jquery-mobile into…
… pagecontainer_load_returns_promise
ff5f377
@marcuskrahl marcuskrahl Merge branch 'pagecontainer_load_returns_promise' of https://github.c…
…om/mk747gx/jquery-mobile into pagecontainer_load_returns_promise
1039f02
@marcuskrahl
Contributor

@arschmitz should be fixed now

@coveralls

Coverage Status

Coverage increased (+0.0%) when pulling 1039f02 on mk747gx:pagecontainer_load_returns_promise into 1dc34cc on jquery:master.

@gabrielschulhof gabrielschulhof modified the milestone: 1.4.3, 1.4.1 Feb 28, 2014
@gabrielschulhof gabrielschulhof added a commit that closed this pull request Mar 11, 2014
@marcuskrahl @gabrielschulhof marcuskrahl + gabrielschulhof Page container: the load method now correctly returns a promise
The API docs for version 1.4.0 state that the load method of the pagecontainer
widget returns a promise. This commit adds this behaviour to the widget to
comply with the docs.

Closes gh-6901
Fixes gh-6900
68d2ccd
@gabrielschulhof gabrielschulhof added a commit that referenced this pull request Mar 11, 2014
@marcuskrahl @gabrielschulhof marcuskrahl + gabrielschulhof Page container: the load method now correctly returns a promise
The API docs for version 1.4.0 state that the load method of the pagecontainer
widget returns a promise. This commit adds this behaviour to the widget to
comply with the docs.

Closes gh-6901
Fixes gh-6900
6fd5e67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment