GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Currently the values we use for swipe start and stop coords are incorrect this fixes them on multiple platforms
Swipe: Fix coords for different platforms to respect vertical threshold
👍 by me
"Inline comments are allowed as an exception when used to annotate special arguments in formal parameter lists"
We should also change the horizontalDistanceThreshold inline comment.
Should add a comment here why the test is commented out and not just removed.
Line break after /* and before */.
Shouldn't changes in the library and changes in tests be in separate commits?
Any chance this fix could be backported into the 1.3.x branch as well?
@ugomobi no the tests are for the change they should be the same commit
@atuttle I'm afraid we've already decided not to make any more 1.3.x releases.
@ugomobi Why would they be in separate commits? If you commit the code first, you have no proof that it works. If you commit the test first, you're going to break the build.
Ok. I wasn't sure about code and tests in different commits because in the past we used to always split those, but I didn't remember the reason why (probably because there was no good reason). After reading Scott's comment it makes completely sense to me to combine them. Thanks.