Panel: Do not scroll to top upon updatelayout #7128

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

gabrielschulhof commented Feb 18, 2014

Fixes gh-6688
Re gh-5535

gabrielschulhof added this to the 1.4.2 milestone Feb 18, 2014

Contributor

gabrielschulhof commented Feb 18, 2014

@ugomobi, could you please verify that this continues to fix #5535? I'm not quite sure how to verify that. It should be OK, since resetActivePageHeight() still gets called.

Contributor

gabrielschulhof commented Feb 18, 2014

@ugomobi I've asked you to take a look before @arschmitz because you made the #5535 fix.

Member

jaspermdegroot commented Feb 18, 2014

@gabrielschulhof

I understand. It looks like this won't affect the fix for #5535 but I want to give it a closer look and do some more functional testing.

Owner

arschmitz commented Feb 23, 2014

this looks good to me @ugomobi have you had a chance to finish looking at this?

Member

jaspermdegroot commented Feb 24, 2014

@gabrielschulhof @arschmitz

I tested this a bit more and it looks good.

Owner

arschmitz commented Feb 24, 2014

👍

gabrielschulhof deleted the 6688-panel-jump-to-top branch Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment