New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup: Add classes option #8040

wants to merge 50 commits into
base: ui-1-12


None yet
5 participants

gabrielschulhof commented Mar 19, 2015

Fixes gh-7686

@gabrielschulhof gabrielschulhof added this to the 1.5.0 milestone Mar 19, 2015

@gabrielschulhof gabrielschulhof deleted the gabrielschulhof:7686-popup-classes-option branch Mar 23, 2015

@gabrielschulhof gabrielschulhof restored the gabrielschulhof:7686-popup-classes-option branch Mar 23, 2015

gabrielschulhof and others added some commits Mar 27, 2015

Popup: pagecontainerbeforechange with reloadPage requires immediate flag
The popup must not prevent default when going back to a page with the same URL
from which it was opened if the reloadPage flag is set. Rather, it must close
immediately, handling the page change event as if the user were navigating to a
different page.

Fixes gh-6119
Closes gh-7929
Build: Include events.js from
events.js was making it into the build only by virtue of the fact that it was
being pulled by navigation.js. In the process of fixing gh-7805 it became clear
that navigation.js doesn't really need events.js. Thus, the reference to
events.js was removed from navigation.js, thereby orphaning events.js from the
build. This rectifies the problem by explicitly adding events.js to the build.

Fixes gh-7925
Closes gh-7926
Panel: no longer jump up on resize
should not scroll to top in just resize window

Fixes gh-7572
Closes gh-7674
Navigation: Remove fallback for browsers lacking dynamic base support
Do not unconditionally inject base tag

Fixes gh-7331
Fixes gh-5757
Fixes gh-7489
Closes gh-7895
Page: Add option enhance
Enhances the page only if the option is on, which, by
default, it is.

Fixes gh-7416
Closes gh-7897
Widgets: Pull in new widgets from ui and remove old widgets
This commit pulls in the new jQuery UI Button, Checkboxradio, controlgroup,
and the jQuery UI Accordion. It also Updates to the newest version of
the widget factory which includes the classes option. This commit includes a
backcompat extension for switching boolean style options to classes option.
Lastely it pulls setting theme out into its own extension.
Tabs: Override _isLocal() to account for Ajax nav
We cannot compare hrefs to location.href

Fixes gh-7169
Fixes gh-7725
Closes gh-7727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment