Demos: Hover state update on Nav Panel, Search Results, all Text links #8389
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
demos/_assets/css/jqm-demos.css
Outdated
| opacity: .75; | ||
| } | ||
|
|
||
| /* Darker hover state for links. Overwriting jquery.mobile.theme.css LN298 */ |
There was a problem hiding this comment.
Remove line number (theme CSS isn't static so the line number will change sooner or later).
|
The changes look good. I noticed one problem. When an accordion is being expanded it gets the green active style, but this style is not removed after the accordion is being collapsed. It remains green until another button gets focus. In the current situation the active style isn't really clear, but it does get removed as soon as the accordion is collapsed (http://view.jquerymobile.com/1.5-demos-issues/demos/). Can you give this a look? Besides that there are a few minor style guide issues. See my comments in the diff. Thanks! |
|
Just pushed the updates.Fixed the style guide spacing and the accordion focus.Let me know if there is anything else. |
| .jqm-navmenu-panel > .ui-panel-inner > .ui-listview li > .ui-listview-item-button:focus, | ||
| .jqm-navmenu-panel > .ui-panel-inner > .ui-listview li > .ui-listview-item-button:active, | ||
| .jqm-navmenu-panel > .ui-panel-inner > .ui-listview li > .ui-accordion-header:hover, | ||
| .jqm-navmenu-panel > .ui-panel-inner > .ui-listview li > .ui-accordion-header:active, |
There was a problem hiding this comment.
.jqm-navmenu-panel > .ui-panel-inner > .ui-listview li > .ui-accordion-header:focus, is missing here
There was a problem hiding this comment.
Yeah, I removed that due to the focus having a dark gray background style remaining on the accordion header after closure.
There was a problem hiding this comment.
Right, that's because it has focus after closing. If you now tab key navigate through the menu, buttons that are links get focus style but buttons that are accordion headers don't. That's bad.
|
Thanks. See my two comments on the diff. After that it's good to land. |
… in the last commit.
|
landed this with other demos issues on 1.5-dev |
|
This wasn't ready to land. We still have to add |
4 participants
Added a bit more contrast to the hover states for the Navigation Panel/Accordion as well as the Search Results Panel.
Darkened the hover state of text links to also give more contrast and make obvious that the link is a link.