Skip to content

Repo: Update the version in package-lock.json as well #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2020
Merged

Repo: Update the version in package-lock.json as well #106

merged 1 commit into from
Dec 7, 2020

Conversation

@mgol
Copy link
Member

@mgol mgol commented Dec 1, 2020 •
edited
Loading

Not doing that caused Sizzle to have an outdated package-lock.json file in its 2.3.5 release that I had to fix afterwards.

@mgol mgol requested review from dmethvin and timmywil December 1, 2020 13:33
@mgol mgol self-assigned this Dec 1, 2020
@mgol mgol force-pushed the package-lock-update branch from 70c5b94 to 506e35c Compare December 1, 2020 16:27
timmywil
timmywil approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@mgol mgol merged commit 0606900 into jquery:master Dec 7, 2020
@mgol mgol deleted the package-lock-update branch December 7, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timmywil timmywil timmywil approved these changes

@dmethvin dmethvin Awaiting requested review from dmethvin

Assignees

@mgol mgol

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgol @timmywil