Check if what we are trying to call is callable before calling it.#77
Closed
digitalxero wants to merge 1 commit into
Closed
Check if what we are trying to call is callable before calling it.#77digitalxero wants to merge 1 commit into
digitalxero wants to merge 1 commit into
Conversation
… of my nested templates newItem.tmpl was getting set as an object or array and would crash here. Adding the check and setting the _ctnt to the obj or array fixed this and cause the templates to parse as expected.
Author
|
No but I will make one tomorrow |
Owner
|
Thanks Digitalxero. Yes, I would also like to see an example of how this happens before integrating this change. There have been cases when people have hit an error on that line of code because they were in fact not using the template APIs correctly... So it would be great to see a complete example... |
Contributor
|
Thanks for taking the time to submit this pull request. Unfortunately this plugin is no longer being actively developed or maintained by the jQuery team. See README for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a safety check to make sure we are calling a function. In several of my nested templates newItem.tmpl was getting set as an object or array and would crash here. Adding the check and setting the _ctnt to the obj or array fixed this and cause the templates to parse as expected.