Skip to content
Permalink
Browse files

Update popup utility: Defer _open call and let click event propagate.

Fixes other popups to close. Also update aria usage.
  • Loading branch information
jzaefferer committed Apr 13, 2011
1 parent 67d49f5 commit 00559b388af76424878413cedcebee49e0a8c67e
Showing with 9 additions and 3 deletions.
  1. +9 −3 tests/visual/menu/popup.js
@@ -29,7 +29,7 @@ $.widget( "ui.popup", {
}

this.options.trigger
.attr( "aria-haspop", true )
.attr( "aria-haspopup", true )
.attr( "aria-owns", this.element.attr( "id" ) );

this.element
@@ -38,9 +38,11 @@ $.widget( "ui.popup", {

this._bind(this.options.trigger, {
click: function( event ) {
event.stopPropagation();
event.preventDefault();
this._open( event );
var that = this;
setTimeout(function() {
that._open( event );
}, 1);
}
});

@@ -68,6 +70,10 @@ $.widget( "ui.popup", {
.removeClass( "ui-popup" )
.removeAttr( "aria-hidden" )
.removeAttr( "aria-expanded" );

this.options.trigger
.removeAttr( "aria-haspopup" )
.removeAttr( "aria-owns" );

if ( this.generatedId ) {
this.element.removeAttr( "id" );

0 comments on commit 00559b3

Please sign in to comment.
You can’t perform that action at this time.