Skip to content
Permalink
Browse files

Slider: Prevent the default action on keydown if we're listening for …

…the pressed key. Fixes #8109 - Slider: Key handling should prevent scrolling.
  • Loading branch information
scottgonzalez committed Feb 9, 2012
1 parent 5189753 commit 0434bce03d1368f5ace043fa50e9d4f95677c09e
Showing with 2 additions and 6 deletions.
  1. +2 −6 ui/jquery.ui.slider.js
@@ -115,8 +115,7 @@ $.widget( "ui.slider", $.ui.mouse, {

this.handles
.keydown(function( event ) {
var ret = true,
index = $( this ).data( "index.ui-slider-handle" ),
var index = $( this ).data( "index.ui-slider-handle" ),
allowed,
curVal,
newVal,
@@ -135,7 +134,7 @@ $.widget( "ui.slider", $.ui.mouse, {
case $.ui.keyCode.RIGHT:
case $.ui.keyCode.DOWN:
case $.ui.keyCode.LEFT:
ret = false;
event.preventDefault();
if ( !self._keySliding ) {
self._keySliding = true;
$( this ).addClass( "ui-state-active" );
@@ -184,9 +183,6 @@ $.widget( "ui.slider", $.ui.mouse, {
}

self._slide( event, index, newVal );

return ret;

})
.keyup(function( event ) {
var index = $( this ).data( "index.ui-slider-handle" );

0 comments on commit 0434bce

Please sign in to comment.
You can’t perform that action at this time.