Skip to content
Permalink
Browse files

Revert "Dialog: Moved the default value for the position.of option in…

…side the _position() method to avoid a bug in jQuery 1.3.2. Fixes #6030 - ui.dialog with jQuery 1.3.2 causes RangeError."

This reverts commit 22671ad.
  • Loading branch information
scottgonzalez committed Dec 10, 2010
1 parent 866c595 commit 0e15f573d6f1d5c138ce63d2a462737dbb874faa
Showing with 3 additions and 1 deletion.
  1. +1 −0 tests/unit/dialog/dialog_defaults.js
  2. +2 −1 ui/jquery.ui.dialog.js
@@ -20,6 +20,7 @@ var dialog_defaults = {
position: {
my: 'center',
at: 'center',
of: window,
collision: 'fit',
using: $.ui.dialog.prototype.options.position.using
},
@@ -57,6 +57,7 @@ $.widget("ui.dialog", {
position: {
my: 'center',
at: 'center',
of: window,
collision: 'fit',
// ensure that the titlebar is never outside the document
using: function(pos) {
@@ -527,7 +528,7 @@ $.widget("ui.dialog", {
this.uiDialog
// workaround for jQuery bug #5781 http://dev.jquery.com/ticket/5781
.css({ top: 0, left: 0 })
.position($.extend({ of: window }, position));
.position(position);
if (!isVisible) {
this.uiDialog.hide();
}

0 comments on commit 0e15f57

Please sign in to comment.
You can’t perform that action at this time.