Skip to content
Permalink
Browse files

Slider: Removing dir option. Implementation caused more damage then b…

…eing useful - will eventually implement RTL support in all widgets.
  • Loading branch information...
jzaefferer committed Oct 25, 2010
1 parent 44ca830 commit 0e7bef4401e84a8440278662b74c5d3c96bc88b8
Showing with 6 additions and 21 deletions.
  1. +3 −15 themes/base/jquery.ui.spinner.css
  2. +3 −6 ui/jquery.ui.spinner.js
@@ -1,24 +1,12 @@
/* Spinner
----------------------------------*/
.ui-spinner { position:relative; display: inline-block; overflow: hidden; padding: 0; vertical-align: middle; height: 1.8em; }
.ui-spinner-input { border: none; background: none; padding: 0; margin: .2em 0; vertical-align: middle; }
.ui-spinner-button { width: 16px; height: 50%; font-size: .5em; padding: 0; margin: 0; z-index: 100; text-align: center; vertical-align: middle; position: absolute; cursor: default; display: block; overflow: hidden; }
.ui-spinner a.ui-spinner-button { border-top: none; border-bottom: none; } /* more specificity required here to overide default borders */
.ui-spinner-input { border: none; background: none; padding: 0; margin: .2em 0; vertical-align: middle; float: left; margin-left: .4em; margin-right: 22px; }
.ui-spinner-button { width: 16px; height: 50%; font-size: .5em; padding: 0; margin: 0; z-index: 100; text-align: center; vertical-align: middle; position: absolute; cursor: default; display: block; overflow: hidden; right: 0; }
.ui-spinner a.ui-spinner-button { border-top: none; border-bottom: none; border-right: none; } /* more specificity required here to overide default borders */
.ui-spinner .ui-icon { position: absolute; margin-top: -8px; top: 50%; left: 0; } /* vertical centre icon */
.ui-spinner-up { top: 0; }
.ui-spinner-down { bottom: 0; }

/* ltr (default) */
.ui-spinner-ltr { direction: ltr; }
.ui-spinner-ltr .ui-spinner-input { float: left; margin-left: .4em; margin-right: 22px; }
.ui-spinner-ltr .ui-spinner-button { right: 0; }
.ui-spinner-ltr a.ui-spinner-button { border-right: none; }

/* rtl */
.ui-spinner-rtl { direction: rtl; }
.ui-spinner-rtl .ui-spinner-input { float: right; margin-left: 22px; margin-right: .4em; }
.ui-spinner-rtl .ui-spinner-button { left: 0; }
.ui-spinner-rtl a.ui-spinner-button { border-left: none; }

/* TR overrides */
div.ui-spinner { background: none; }
@@ -21,7 +21,6 @@ var hover = 'ui-state-hover',

$.widget('ui.spinner', {
options: {
dir: 'ltr',
incremental: true,
max: Number.MAX_VALUE,
min: -Number.MAX_VALUE,
@@ -138,13 +137,11 @@ $.widget('ui.spinner', {
self.uiSpinner = uiSpinner;
},
_uiSpinnerHtml: function() {
return '<div role="spinbutton" class="ui-spinner ui-state-default ui-widget ui-widget-content ui-corner-all ui-spinner-' + this.options.dir + '"></div>';
return '<div role="spinbutton" class="ui-spinner ui-state-default ui-widget ui-widget-content ui-corner-all"></div>';
},
_buttonHtml: function() {
return '<a class="ui-spinner-button ui-spinner-up ui-corner-t' + this.options.dir.substr(-1,1) +
'"><span class="ui-icon ui-icon-triangle-1-n">&#9650;</span></a>' +
'<a class="ui-spinner-button ui-spinner-down ui-corner-b' + this.options.dir.substr(-1,1) +
'"><span class="ui-icon ui-icon-triangle-1-s">&#9660;</span></a>';
return '<a class="ui-spinner-button ui-spinner-up ui-corner-tr"><span class="ui-icon ui-icon-triangle-1-n">&#9650;</span></a>' +
'<a class="ui-spinner-button ui-spinner-down ui-corner-br"><span class="ui-icon ui-icon-triangle-1-s">&#9660;</span></a>';
},
_start: function(event) {
if (!this.spinning && this._trigger('start', event, { value: this.value()}) !== false) {

0 comments on commit 0e7bef4

Please sign in to comment.
You can’t perform that action at this time.