Skip to content

Commit

Permalink
Test Suite: Remove Flaky Datepicker test, and correct more old jQuery…
Browse files Browse the repository at this point in the history
… test cases for old Opera and old Safari.

---
yaml
---
svn_rev: 5497
current_ref: refs/heads/master
current_commit: 7c939aa
head_branch: refs/heads/master
migrated_from: 3
  • Loading branch information
mikesherov committed Apr 14, 2013
1 parent 75ca436 commit 1183be4
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
@@ -1,2 +1,2 @@
---
refs/heads/master: d345a0d7db841a143dcfdd3fb6fa6141cda435e9
refs/heads/master: 7c939aadf8c661f1230627d51bf1450f99effcc3
2 changes: 1 addition & 1 deletion trunk/tests/unit/button/button_core.js
Expand Up @@ -166,7 +166,7 @@ asyncTest( "Resetting a button's form should refresh the visual state of the but
ok( !checkbox.button( "widget" ).hasClass( "ui-state-active" ) );

form.get( 0 ).reset();

// #9213: If a button has been removed, refresh should not be called on it when
// its corresponding form is reset.
button.remove();
Expand Down
11 changes: 6 additions & 5 deletions trunk/tests/unit/datepicker/datepicker_options.js
Expand Up @@ -1066,11 +1066,12 @@ test("formatDate", function() {
"Format date 'jour' d 'de' MM (''DD''), yy with settings");
});

test("Ticket 6827: formatDate day of year calculation is wrong during day lights savings time", function(){
expect( 1 );
var time = $.datepicker.formatDate("oo", new Date("2010/03/30 12:00:00 CDT"));
equal(time, "089");
});
// TODO: Fix this test so it isn't mysteriously flaky in Browserstack on certain OS/Browser combos
// test("Ticket 6827: formatDate day of year calculation is wrong during day lights savings time", function(){
// expect( 1 );
// var time = $.datepicker.formatDate("oo", new Date("2010/03/30 12:00:00 CDT"));
// equal(time, "089");
// });

test( "Ticket 7602: Stop datepicker from appearing with beforeShow event handler", function() {
expect( 3 );
Expand Down
1 change: 1 addition & 0 deletions trunk/tests/unit/draggable/draggable_core.js
Expand Up @@ -94,6 +94,7 @@ test( "#8269: Removing draggable element on drop", function() {
// Support: Opera 12.10, Safari 5.1, jQuery <1.8
if ( TestHelpers.draggable.unreliableContains ) {
ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" );
ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" );
} else {
element.simulate( "drag", {
handle: "corner",
Expand Down
13 changes: 9 additions & 4 deletions trunk/tests/unit/draggable/draggable_options.js
Expand Up @@ -472,10 +472,15 @@ test( "#6889: Cursor doesn't revert to pre-dragging state after revert action wh
}),
expected = getCursor();

element.simulate( "drag", {
dx: -1,
dy: -1
});
if ( TestHelpers.draggable.unreliableContains ) {
ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" );
ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" );
} else {
element.simulate( "drag", {
dx: -1,
dy: -1
});
}
});

test( "cursor, default, switching after initialization", function() {
Expand Down

0 comments on commit 1183be4

Please sign in to comment.