Skip to content
Permalink
Browse files

Autocomplete: Fixed a few places that got missed during the change to…

… always keep the menu element around.

Fixes a bug where opening the menu using the arrow keys would cycle through the options, but not show the menu. There's now a bug where you have to arrow too many times to get into the menu when showing the menu by using the arrow keys.
  • Loading branch information
scottgonzalez committed Feb 8, 2010
1 parent f349f90 commit 1402650134da47f48f6631b98b102f499936c752
Showing with 4 additions and 7 deletions.
  1. +4 −7 ui/jquery.ui.autocomplete.js
@@ -92,7 +92,7 @@ $.widget( "ui.autocomplete", {
this.response = function() {
return self._response.apply( self, arguments );
};
this.menu = $("<ul></ul>")
this.menu = $( "<ul></ul>" )
.addClass( "ui-autocomplete" )
.appendTo( this.element.parent() )
.menu({
@@ -139,9 +139,7 @@ $.widget( "ui.autocomplete", {
.removeAttr( "role" )
.removeAttr( "aria-autocomplete" )
.removeAttr( "aria-haspopup" );
if ( this.menu ) {
this.menu.element.remove();
}
this.menu.element.remove();
$.Widget.prototype.destroy.call( this );
},

@@ -237,8 +235,7 @@ $.widget( "ui.autocomplete", {
},

_suggest: function( items ) {
this.menu.element.empty();
var ul = this.menu.element;
var ul = this.menu.element.empty();
$.each( items, function( index, item ) {
$( "<li></li>" )
.data( "item.autocomplete", item )
@@ -253,7 +250,7 @@ $.widget( "ui.autocomplete", {
},

_move: function( direction, event ) {
if ( !this.menu ) {
if ( !this.menu.element.is(":visible") ) {
this.search( null, event );
return;
}

0 comments on commit 1402650

Please sign in to comment.
You can’t perform that action at this time.