Skip to content
Permalink
Browse files

Dialog: address review comments

  • Loading branch information...
arschmitz committed Sep 16, 2015
1 parent 6b05034 commit 1beeb941964ac135c1f1889f8d64ab1d50e1e950
Showing with 4 additions and 4 deletions.
  1. +4 −4 tests/unit/dialog/options.js
@@ -165,7 +165,7 @@ test( "buttons - advanced", function( assert ) {
buttons = element.dialog( "widget" ).find( ".ui-dialog-buttonpane button" );
equal( buttons.length, 1, "correct number of buttons" );
equal( buttons.attr( "id" ), "my-button-id", "correct id" );
equal( buttons.text(), " a button", "correct label" );
equal( buttons.text().trim(), "a button", "correct label" );
assert.hasClasses( buttons, "additional-class" );
deepEqual( buttons.button( "option", "icon" ), "ui-icon-cancel" );
equal( buttons.button( "option", "showLabel" ), false );
@@ -209,17 +209,17 @@ test( "closeText", function() {
expect( 3 );

var element = $( "<div></div>" ).dialog();
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text(), " Close",
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text().trim(), "Close",
"default close text" );
element.remove();

element = $( "<div></div>" ).dialog( { closeText: "foo" } );
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text(), " foo",
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text().trim(), "foo",
"closeText on init" );
element.remove();

element = $( "<div></div>" ).dialog().dialog( "option", "closeText", "bar" );
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text(), " bar",
equal( element.dialog( "widget" ).find( ".ui-dialog-titlebar-close" ).text().trim(), "bar",
"closeText via option method" );
element.remove();
} );

0 comments on commit 1beeb94

Please sign in to comment.
You can’t perform that action at this time.