Skip to content
Permalink
Browse files

Dialog: Remove animation stopping in destroy

Effects wrappers are no longer used, so the workaround and test are no
longer necessary.

This fixes tests in IE8 with jQuery 1.7.

Effectively a complete revert of 13505e5

Closes gh-1481
  • Loading branch information
scottgonzalez committed Mar 10, 2015
1 parent a6a18d1 commit 1f9821c000adbf2ebeccacf9506a7df68956574b
Showing with 1 addition and 11 deletions.
  1. +0 −1 tests/unit/dialog/dialog.html
  2. +0 −9 tests/unit/dialog/dialog_options.js
  3. +1 −1 ui/dialog.js
@@ -22,7 +22,6 @@
"ui/button.js",
"ui/effect.js",
"ui/effect-blind.js",
"ui/effect-clip.js",
"ui/effect-explode.js",
"ui/dialog.js"
]
@@ -283,15 +283,6 @@ test("height", function() {
element.remove();
});

asyncTest( "hide, #5860 - don't leave effects wrapper behind", function() {
expect( 1 );
$( "#dialog1" ).dialog({ hide: "clip" }).dialog( "close" ).dialog( "destroy" );
setTimeout(function() {
equal( $( ".ui-effects-wrapper" ).length, 0 );
start();
}, 500);
});

test("maxHeight", function() {
expect(3);

@@ -168,7 +168,7 @@ return $.widget( "ui.dialog", {
// Without detaching first, the following becomes really slow
.detach();

this.uiDialog.stop( true, true ).remove();
this.uiDialog.remove();

if ( this.originalTitle ) {
this.element.attr( "title", this.originalTitle );

0 comments on commit 1f9821c

Please sign in to comment.
You can’t perform that action at this time.