Permalink
Browse files

Tooltip: Remove name attribute from elements in the live region

Fixes #11272
Closes gh-1544
  • Loading branch information...
jiabaowu authored and scottgonzalez committed Apr 22, 2015
1 parent adcc8ef commit 2cef124bf27ce89f1fbfc493352ebfd895b40822
Showing with 26 additions and 0 deletions.
  1. +25 −0 tests/unit/tooltip/core.js
  2. +1 −0 ui/tooltip.js
View
@@ -221,4 +221,29 @@ asyncTest( "multiple active delegated tooltips", function() {
step1();
});
// http://bugs.jqueryui.com/ticket/11272
test( "remove conflicting attributes from live region", function() {
expect( 2 );
var element = $(
"<div id='content'>" +
"<input type='radio' name='hobby' id='hobby1' checked='checked'>" +
"<label for='hobby1'>option 1</label>" +
"<input type='radio' name='hobby' id='hobby2'>" +
"<label for='hobby2'>option 2</label>" +
"</div>" );
$( "#tooltipped1" )
.tooltip({
content: element,
open: function() {
equal( $( ".ui-helper-hidden-accessible [name]" ).length, 0,
"no name attributes within live region" );
equal( $( ".ui-helper-hidden-accessible [id]" ).length, 0,
"no id attributes within live region" );
}
})
.tooltip( "open" );
});
} );
View
@@ -287,6 +287,7 @@ $.widget( "ui.tooltip", {
// Voiceover will sometimes re-read the entire log region's contents from the beginning
this.liveRegion.children().hide();
a11yContent = $( "<div>" ).html( tooltip.find( ".ui-tooltip-content" ).html() );
a11yContent.removeAttr( "name" ).find( "[name]" ).removeAttr( "name" );
a11yContent.removeAttr( "id" ).find( "[id]" ).removeAttr( "id" );
a11yContent.appendTo( this.liveRegion );

0 comments on commit 2cef124

Please sign in to comment.