Permalink
Browse files

Tabs: Avoid memory leak during refresh

Fixes #10056
Ref gh-1319
  • Loading branch information...
scottgonzalez committed Aug 20, 2014
1 parent b397294 commit 2e8e52dec1eaa06ed170a0ed9769c7b97129c955
Showing with 11 additions and 1 deletion.
  1. +11 −1 ui/tabs.js
View
@@ -372,7 +372,10 @@ return $.widget( "ui.tabs", {
},
_processTabs: function() {
var that = this;
var that = this,
prevTabs = this.tabs,
prevAnchors = this.anchors,
prevPanels = this.panels;
this.tablist = this._getList()
.addClass( "ui-tabs-nav ui-helper-reset ui-helper-clearfix ui-widget-header ui-corner-all" )
@@ -456,6 +459,13 @@ return $.widget( "ui.tabs", {
this.panels
.addClass( "ui-tabs-panel ui-widget-content ui-corner-bottom" )
.attr( "role", "tabpanel" );
// Avoid memory leaks (#10056)
if ( prevTabs ) {
this._off( prevTabs.not( this.tabs ) );
this._off( prevAnchors.not( this.anchors ) );
this._off( prevPanels.not( this.panels ) );
}
},
// allow overriding how to find the list for rare usage scenarios (#7715)

0 comments on commit 2e8e52d

Please sign in to comment.