Skip to content
Permalink
Browse files

Dialog: Create modal overlay after dialog is shown and check scrollHe…

…ight and offsetHeight in all IE versions. Fixed #4995 - Modal Dialog's overlay dissapears in IE when content is tall
  • Loading branch information...
kborchers committed May 12, 2011
1 parent 1845015 commit 331c4602a9a54d9bfa21c660feadeaa995537446
Showing with 3 additions and 3 deletions.
  1. +3 −3 ui/jquery.ui.dialog.js
@@ -281,10 +281,10 @@ $.widget("ui.dialog", {
options = self.options,
uiDialog = self.uiDialog;

self.overlay = options.modal ? new $.ui.dialog.overlay( self ) : null;
self._size();
self._position( options.position );
uiDialog.show( options.show );
self.overlay = options.modal ? new $.ui.dialog.overlay( self ) : null;
self.moveToTop( true );

// prevent tabbing out of modal dialogs
@@ -755,8 +755,8 @@ $.extend( $.ui.dialog.overlay, {
height: function() {
var scrollHeight,
offsetHeight;
// handle IE 6
if ( $.browser.msie && $.browser.version < 7 ) {
// handle IE
if ( $.browser.msie ) {
scrollHeight = Math.max(
document.documentElement.scrollHeight,
document.body.scrollHeight

0 comments on commit 331c460

Please sign in to comment.
You can’t perform that action at this time.