Skip to content
Permalink
Browse files

Grunt: Replace custom rimraf-based clean task with grunt-contrib's cl…

…ean task
  • Loading branch information
jzaefferer committed Jun 14, 2012
1 parent 43c6663 commit 38aac3770cc1e22e5e7225b90c47b37d857be13a
Showing with 3 additions and 5 deletions.
  1. +0 −4 build/tasks/build.js
  2. +2 −0 grunt.js
  3. +1 −1 package.json
@@ -181,10 +181,6 @@ grunt.registerTask( "copy_themes", function() {
});
});

grunt.registerTask( "clean", function() {
require( "rimraf" ).sync( "dist" );
});

grunt.registerTask( "authors", function() {
var done = this.async();

@@ -81,6 +81,7 @@ uiFiles.forEach(function( file ) {
});

// grunt plugins
grunt.loadNpmTasks( "grunt-contrib" );
grunt.loadNpmTasks( "grunt-css" );
grunt.loadNpmTasks( "grunt-html" );
grunt.loadNpmTasks( "grunt-compare-size" );
@@ -131,6 +132,7 @@ grunt.initConfig({
bannerCSS: createBanner( cssFiles )
},
compare_size: compareFiles,
clean: ["dist"],
concat: {
ui: {
src: [ "<banner:meta.bannerAll>", stripBanner( uiFiles ) ],
@@ -27,12 +27,12 @@
"dependencies": {},
"devDependencies": {
"grunt": "0.3.9",
"grunt-contrib": "0.0.7",
"grunt-css": "0.2.0",
"grunt-compare-size": "0.1.4",
"grunt-html": "0.1.1",
"grunt-junit": "0.1.4",
"request": "2.9.153",
"rimraf": "2.0.1",
"testswarm": "0.2.2"
},
"keywords": []

4 comments on commit 38aac37

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez replied Jun 16, 2012

This seems like a silly change. We now have a dependency on CoffeeScript if we want to build jQuery UI.

@scottgonzalez

This comment has been minimized.

Copy link
Member

scottgonzalez replied Jun 16, 2012

The dependency on CoffeeScript bothers me because npm install will fail for most people. Also, grunt-contrib is pretty big and we're using it to remove 2 lines of code.

@jzaefferer

This comment has been minimized.

Copy link
Member Author

jzaefferer replied Jun 16, 2012

The idea was to also use their zip/compress task. Not that important, so I'll revert this.

@jzaefferer

This comment has been minimized.

Copy link
Member Author

jzaefferer replied Jun 16, 2012

Reverted in 4f3c1e9

Please sign in to comment.
You can’t perform that action at this time.