Skip to content
Permalink
Browse files
Menu: Remove the requirement to use anchors in menu items
  • Loading branch information
@kborchers
kborchers committed Oct 6, 2013
1 parent e14f75e commit 3a61627
Show file tree
Hide file tree
Showing 8 changed files with 240 additions and 265 deletions.
44 demos/menu/default.html
View file
@@ -22,42 +22,38 @@
<body>

<ul id="menu">
<li class="ui-state-disabled"><a href="#">Aberdeen</a></li>
<li><a href="#">Ada</a></li>
<li><a href="#">Adamsville</a></li>
<li><a href="#">Addyston</a></li>
<li>
<a href="#">Delphi</a>
<li class="ui-state-disabled">Aberdeen</li>
<li>Ada</li>
<li>Adamsville</li>
<li>Addyston</li>
<li>Delphi
<ul>
<li class="ui-state-disabled"><a href="#">Ada</a></li>
<li><a href="#">Saarland</a></li>
<li><a href="#">Salzburg</a></li>
<li class="ui-state-disabled">Ada</li>
<li>Saarland</li>
<li>Salzburg</li>
</ul>
</li>
<li><a href="#">Saarland</a></li>
<li>
<a href="#">Salzburg</a>
<li>Saarland</li>
<li>Salzburg
<ul>
<li>
<a href="#">Delphi</a>
<li>Delphi
<ul>
<li><a href="#">Ada</a></li>
<li><a href="#">Saarland</a></li>
<li><a href="#">Salzburg</a></li>
<li>Ada</li>
<li>Saarland</li>
<li>Salzburg</li>
</ul>
</li>
<li>
<a href="#">Delphi</a>
<li>Delphi
<ul>
<li><a href="#">Ada</a></li>
<li><a href="#">Saarland</a></li>
<li><a href="#">Salzburg</a></li>
<li>Ada</li>
<li>Saarland</li>
<li>Salzburg</li>
</ul>
</li>
<li><a href="#">Perch</a></li>
<li>Perch</li>
</ul>
</li>
<li class="ui-state-disabled"><a href="#">Amesville</a></li>
<li class="ui-state-disabled">Amesville</li>
</ul>

<div class="demo-description">

8 comments on commit 3a61627

@aklaver
Copy link

@aklaver aklaver commented on 3a61627 Dec 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how are you supposed to include a link in a menu item now and not have the styling be thrown off?

@lankymart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aklaver No idea I'm afraid, tried to inform the owner even filled in a bug report but it was ignored and the bug was set to fixed with no explanation. So I give up and stopped using the autocomplete component.

@aklaver
Copy link

@aklaver aklaver commented on 3a61627 Dec 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am not understanding what it was supposed to fix and why something that works no longer works. Seems like a regression to me.

@jzaefferer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting on commits is not a good option for reporting issues. In this case, the issue is likely already addressed: de2ef2a

@aklaver
Copy link

@aklaver aklaver commented on 3a61627 Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the above has to do with

, I'm talking about losing the ability to use in a menu item. I will file an issue.

@lankymart
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aklaver @jzaefferer If you read the above notes I already posted a bug report which was ignored.

@jzaefferer
Copy link
Member

@jzaefferer jzaefferer commented on 3a61627 Dec 8, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aklaver
Copy link

@aklaver aklaver commented on 3a61627 Dec 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue filed, https://bugs.jqueryui.com/ticket/14885#ticket

Please sign in to comment.