Skip to content
Permalink
Browse files

CSS: remove spaces from opacity filters so themeRoller can replace pr…

…operly
  • Loading branch information
mikesherov committed Nov 20, 2012
1 parent 010e09f commit 3c6c22b179787a118538f70c0cd56a778a16adba
Showing with 4 additions and 2 deletions.
  1. +4 −2 themes/base/jquery.ui.theme.css
@@ -403,13 +403,15 @@
/* Overlays */
.ui-widget-overlay {
background: #aaaaaa/*{bgColorOverlay}*/ url(images/ui-bg_flat_0_aaaaaa_40x100.png)/*{bgImgUrlOverlay}*/ 50%/*{bgOverlayXPos}*/ 50%/*{bgOverlayYPos}*/ repeat-x/*{bgOverlayRepeat}*/;
opacity: .3; filter:Alpha(Opacity=30)/*{opacityOverlay}*/;
/* no space between ".3;" and "filter" because themeRoller looks back to the first space for replacement */

This comment has been minimized.

Copy link
@selfthinker

selfthinker Nov 20, 2012

Contributor

Adding a comment is a good idea. But the fact that those two declarations are on the same line is in more need of an explanation than the missing space. As that is a violation of the coding standard, in case someone else will later try to "fix" it, it's better to explain that it's intentional.
I had written "the following opacity declarations need to stay on the same line for ThemeRoller". Maybe extend that to "the following opacity declarations need to stay on the same line and must not have any space between them for ThemeRoller"

This comment has been minimized.

Copy link
@mikesherov

mikesherov Nov 20, 2012

Author Member

I felt that mentioning no space implied that they were on the same line, and I thought that explaining why it is necessary was more important than just explaining that it was necessary.

In all honesty, I'd prefer if themeRoller itself did two separate replacements, removing this requirement, although it may be much ado about nothing.

Thoughts?

This comment has been minimized.

Copy link
@scottgonzalez

scottgonzalez Nov 20, 2012

Member

I think the current comment is clear. I agree it'd be nice to be able to split them and just get rid of the comment. @rxaviers Can you update TR to make this work? We'd need to add a new variable (something like opacityFilterOverlay), which is calculated on the server based on the existing variable. We'd also need to handle opacityOverlay differently for >=1.10.0 and <1.10.0.

opacity: .3;filter:Alpha(Opacity=30)/*{opacityOverlay}*/;
}
.ui-widget-shadow {
margin: -8px/*{offsetTopShadow}*/ 0 0 -8px/*{offsetLeftShadow}*/;
padding: 8px/*{thicknessShadow}*/;
background: #aaaaaa/*{bgColorShadow}*/ url(images/ui-bg_flat_0_aaaaaa_40x100.png)/*{bgImgUrlShadow}*/ 50%/*{bgShadowXPos}*/ 50%/*{bgShadowYPos}*/ repeat-x/*{bgShadowRepeat}*/;
opacity: .3; filter:Alpha(Opacity=30)/*{opacityShadow}*/;
/* no space between ".3;" and "filter" because themeRoller looks back to the first space for replacement */
opacity: .3;filter:Alpha(Opacity=30)/*{opacityShadow}*/;
-moz-border-radius: 8px/*{cornerRadiusShadow}*/;
-khtml-border-radius: 8px/*{cornerRadiusShadow}*/;
-webkit-border-radius: 8px/*{cornerRadiusShadow}*/;

2 comments on commit 3c6c22b

@rxaviers

This comment has been minimized.

Copy link
Member

rxaviers replied Nov 20, 2012

@rxaviers

This comment has been minimized.

Copy link
Member

rxaviers replied Dec 28, 2012

ThemeRoller updated.
jquery-ui update is on PR #870

Please sign in to comment.
You can’t perform that action at this time.