Permalink
Show file tree
Hide file tree
1 comment
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Core: Move version and creation of the ui namespace into its own module
Ref #9647
- Loading branch information
Showing
39 changed files
with
60 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -25,6 +25,7 @@ | ||
"./core", | ||
"./widget", | ||
"./position", | ||
"./version", | ||
"./menu" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define([ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -22,7 +22,8 @@ | ||
// AMD. Register as an anonymous module. | ||
define([ | ||
"jquery", | ||
"./core" | ||
"./core", | ||
"./version" | ||
], factory ); | ||
} else { | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -28,7 +28,8 @@ | ||
"./draggable", | ||
"./mouse", | ||
"./position", | ||
"./resizable" | ||
"./resizable", | ||
"./version" | ||
], factory ); | ||
} else { | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -21,6 +21,7 @@ | ||
define([ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./mouse", | ||
"./widget" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,7 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define([ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget", | ||
"./mouse", | ||
"./draggable" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect", | ||
"./effect-scale" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect", | ||
"./effect-size" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -19,6 +19,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./version", | ||
"./effect" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -4,7 +4,8 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"ui/core" | ||
"ui/core", | ||
"./version" | ||
], factory ); | ||
} else { | ||
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget", | ||
"./position" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -18,6 +18,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define([ | ||
"jquery", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -22,7 +22,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define([ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./mouse", | ||
"./widget" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -20,7 +20,7 @@ | ||
// AMD. Register as an anonymous module. | ||
define([ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./mouse", | ||
"./widget" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget", | ||
"./position", | ||
"./menu" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -24,6 +24,7 @@ | ||
"jquery", | ||
"./core", | ||
"./mouse", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -22,6 +22,7 @@ | ||
"jquery", | ||
"./core", | ||
"./mouse", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget", | ||
"./button" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget" | ||
], factory ); | ||
} else { | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -23,6 +23,7 @@ | ||
define( [ | ||
"jquery", | ||
"./core", | ||
"./version", | ||
"./widget", | ||
"./position" | ||
], factory ); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
( function( factory ) { | ||
if ( typeof define === "function" && define.amd ) { | ||
|
||
// AMD. Register as an anonymous module. | ||
define( [ "jquery" ], factory ); | ||
} else { | ||
|
||
// Browser globals | ||
factory( jQuery ); | ||
} | ||
} ( function( $ ) { | ||
|
||
$.ui = $.ui || {}; | ||
|
||
return $.ui.version = "@VERSION"; | ||
|
||
} ) ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d71fb8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit made my code break. I rely on the following line in position.js:
$.ui = $.ui || {};
I did not have any other dependency than position.js till now. Now, I need add version.js as another dependency. However, I liked being able to use only a single js file...