Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Selectmenu: changed from return false to event.preventDefault()

  • Loading branch information...
commit 3e1557b654e88852ef405422d13eb035dc33e929 1 parent fd69abb
@fnagel fnagel authored
Showing with 6 additions and 8 deletions.
  1. +6 −8 ui/jquery.ui.selectmenu.js
View
14 ui/jquery.ui.selectmenu.js
@@ -100,18 +100,17 @@ $.widget( "ui.selectmenu", {
return false;
},
'keydown.selectmenu': function( event ) {
- var ret = true;
switch (event.keyCode) {
case $.ui.keyCode.TAB:
if ( self.opened ) self.close();
break;
case $.ui.keyCode.ENTER:
if ( self.opened ) self.list.menu( "select", self._getSelectedItem() );
- ret = false;
+ event.preventDefault();
break;
case $.ui.keyCode.SPACE:
self._toggle(event);
- ret = false;
+ event.preventDefault();
break;
case $.ui.keyCode.UP:
if ( event.altKey ) {
@@ -119,7 +118,7 @@ $.widget( "ui.selectmenu", {
} else {
self._move( "previous", event );
}
- ret = false;
+ event.preventDefault();
break;
case $.ui.keyCode.DOWN:
if ( event.altKey ) {
@@ -127,20 +126,19 @@ $.widget( "ui.selectmenu", {
} else {
self._move( "next", event );
}
- ret = false;
+ event.preventDefault();
break;
case $.ui.keyCode.LEFT:
self._move( "previous", event );
- ret = false;
+ event.preventDefault();
break;
case $.ui.keyCode.RIGHT:
self._move( "next", event );
- ret = false;
+ event.preventDefault();
break;
default:
self.list.trigger( event );
}
- return ret;
}
});
Please sign in to comment.
Something went wrong with that request. Please try again.