Tabs: jQuery <1.7.2 treats .data() as a getter if the value to set is…

… undefined.
jquery · Jun 11, 2012 · 4866182 · 4866182
1 parent aa1e8b5
commit 4866182
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/ui/jquery.ui.tabs.js b/ui/jquery.ui.tabs.js
@@ -384,7 +384,8 @@ $.widget( "ui.tabs", {
 		this.anchors.each(function( i, anchor ) {
 			var selector, panel, panelId,
 				anchorId = $( anchor ).uniqueId().attr( "id" ),
-				tab = $( anchor ).closest( "li" );
+				tab = $( anchor ).closest( "li" ),
+				originalAriaControls = tab.attr( "aria-controls" );
 
 			// inline tab
 			if ( isLocal( anchor ) ) {
@@ -405,12 +406,13 @@ $.widget( "ui.tabs", {
 			if ( panel.length) {
 				that.panels = that.panels.add( panel );
 			}
-			tab
+			if ( originalAriaControls ) {
-				.data( "ui-tabs-aria-controls", tab.attr( "aria-controls" ) )
+				tab.data( "ui-tabs-aria-controls", originalAriaControls );
-				.attr({
+			}
-					"aria-controls": selector.substring( 1 ),
+			tab.attr({
-					"aria-labelledby": anchorId
+				"aria-controls": selector.substring( 1 ),
-				});
+				"aria-labelledby": anchorId
+			});
 			panel.attr( "aria-labelledby", anchorId );
 		});