Skip to content
Permalink
Browse files

UI Tabs: fixed broken animations and the frequently reported "jumpyne…

…ss", fixes #3872
  • Loading branch information
Klaus Hartl
Klaus Hartl committed Jan 21, 2009
1 parent fe303b4 commit 4af30fece37b0b3525d08b6920b9a60f093bb77f
Showing with 7 additions and 7 deletions.
  1. +7 −7 ui/ui.tabs.js
@@ -233,7 +233,7 @@ $.widget("ui.tabs", {
// set up animations
var hideFx, showFx;
if (o.fx) {
if (o.fx.constructor == Array) {
if ($.isArray(o.fx)) {
hideFx = o.fx[0];
showFx = o.fx[1];
}
@@ -250,11 +250,11 @@ $.widget("ui.tabs", {
// Show a tab...
var showTab = showFx ?
function(clicked, $show) {
$show.animate(showFx, showFx.duration || 'normal', function() {
$show.removeClass('ui-tabs-hide');
resetStyle($show, showFx);
self._trigger('show', null, self.ui(clicked, $show[0]));
});
$show.hide().removeClass('ui-tabs-hide') // avoid flicker that way
.animate(showFx, 500, function() {
resetStyle($show, showFx);
self._trigger('show', null, self.ui(clicked, $show[0]));
});
} :
function(clicked, $show) {
$show.removeClass('ui-tabs-hide');
@@ -267,7 +267,7 @@ $.widget("ui.tabs", {
$hide.animate(hideFx, hideFx.duration || 'normal', function() {
$hide.addClass('ui-tabs-hide');
resetStyle($hide, hideFx);
if ($show) showTab(clicked, $show, $hide);
if ($show) showTab(clicked, $show);
});
} :
function(clicked, $hide, $show) {

0 comments on commit 4af30fe

Please sign in to comment.
You can’t perform that action at this time.