Skip to content
Permalink
Browse files

argument shifting is not done correctly when the options argument is …

…not supplied. the result is that the callback is not called. this fixes Ticket #5731 foooo
  • Loading branch information...
kobrigo authored and jzaefferer committed Jun 16, 2010
1 parent 06f721b commit 4be0942af0d0a73541148899fbb2e0c406795c79
Showing with 5 additions and 5 deletions.
  1. +5 −5 ui/jquery.effects.core.js
@@ -418,15 +418,15 @@ function _normalizeArguments(effect, options, speed, callback) {
speed = null;
options = {};
}
if ($.isFunction(speed)) {
callback = speed;
speed = null;
}
if (typeof options == 'number' || $.fx.speeds[options]) {
if (typeof options == 'number' || $.fx.speeds[options]) {
callback = speed;
speed = options;
options = {};
}
if ($.isFunction(speed)) {
callback = speed;
speed = null;
}

options = options || {};

1 comment on commit 4be0942

@scottgonzalez

This comment has been minimized.

Copy link
Member

commented on 4be0942 Dec 10, 2013

@kobrigo Can you please sign our CLA?

Please sign in to comment.
You can’t perform that action at this time.