argument shifting is not done correctly when the options argument is …

…not supplied. the result is that the callback is not called. this fixes Ticket #5731 foooo
jquery · Jul 16, 2010 · 4be0942 · 4be0942 · scottgonzalez · Dec 10, 2013
1 parent 06f721b
commit 4be0942
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/ui/jquery.effects.core.js b/ui/jquery.effects.core.js
@@ -418,15 +418,15 @@ function _normalizeArguments(effect, options, speed, callback) {
 		speed = null;
 		options = {};
 	}
-	if ($.isFunction(speed)) {
+        if (typeof options == 'number' || $.fx.speeds[options]) {
-		callback = speed;
-		speed = null;
-	}
-	if (typeof options == 'number' || $.fx.speeds[options]) {
 		callback = speed;
 		speed = options;
 		options = {};
 	}
+	if ($.isFunction(speed)) {
+		callback = speed;
+		speed = null;
+	}
 
 	options = options || {};