Skip to content
Permalink
Browse files

Dialog: If the browser doesn't support minHeight, use height to set t…

…he minHeight. Fixes #6027 - Dialog: minHeight isn't properly handled on init in IE6.
  • Loading branch information...
scottgonzalez committed Sep 7, 2010
1 parent 99694e6 commit 52e543a63760d9e9ca17e04e796ca80646326f4a
Showing with 2 additions and 1 deletion.
  1. +2 −1 ui/jquery.ui.dialog.js
@@ -649,7 +649,8 @@ $.widget("ui.dialog", {
this.element
.css(options.height === 'auto' ? {
minHeight: Math.max(options.minHeight - nonContentHeight, 0),
height: 'auto'
height: $.support.minHeight ? 'auto' :
Math.max(options.minHeight - nonContentHeight, 0)
} : {
minHeight: 0,
height: Math.max(options.height - nonContentHeight, 0)

2 comments on commit 52e543a

@ocombe

This comment has been minimized.

Copy link

replied Sep 20, 2010

This modification triggered a bug for a few clients on chrome, their window had a height of ~50px, i had to revert this change to get the normal behaviour (or I could add width: 'auto' in modal options for all my modals but hey, too boring ^^)
but I don't know why they had this bug, I couldn't reproduce it on chrome myself

@scottgonzalez

This comment has been minimized.

Copy link
Member Author

replied Sep 20, 2010

This shouldn't affect Chrome at all since it supports minHeight.

Please sign in to comment.
You can’t perform that action at this time.