Permalink
Browse files

Autocomplete: Don't update the value of the text field until after se…

…tting focus. Fixes #5639 - Cursor jumps to beginning on select.
  • Loading branch information...
1 parent 5e3755a commit 53489b502dc51edb7707de80ead77549bd529e3a @scottgonzalez scottgonzalez committed Jul 19, 2010
Showing with 8 additions and 2 deletions.
  1. +8 −2 ui/jquery.ui.autocomplete.js
@@ -132,9 +132,12 @@ $.widget( "ui.autocomplete", {
}
},
selected: function( event, ui ) {
- var item = ui.item.data( "item.autocomplete" );
+ var item = ui.item.data( "item.autocomplete" ),
+ setValue = false;
if ( false !== self._trigger( "select", event, { item: item } ) ) {
- self.element.val( item.value );
+ // #5639 - if we set the value before setting focus
+ // the cursor will move to the beginning of the field in IE
+ setValue = true;
}
self.close( event );
// only trigger when focus was lost (click on menu)
@@ -144,6 +147,9 @@ $.widget( "ui.autocomplete", {
self.previous = previous;
}
self.selectedItem = item;
+ if ( setValue ) {
+ self.element.val( item.value );
+ }
},
blur: function( event, ui ) {
if ( self.menu.element.is(":visible") ) {

0 comments on commit 53489b5

Please sign in to comment.