Skip to content
Permalink
Browse files

Build: Update jscs and fix some code style issues

Disables the checks for casing and line length, since those need a lot
more effort to address. For variable naming the fix isn't obvious to me.
There's way too many lines over 100 chars.
  • Loading branch information...
jzaefferer committed Aug 13, 2014
1 parent ba5a60e commit 54004c85d02ba5688549736e0fb8f883c88b668b
Showing with 16 additions and 10 deletions.
  1. +0 −3 .jscs.json
  2. +9 −0 .jscsrc
  3. +1 −1 build/tasks/testswarm.js
  4. +1 −1 package.json
  5. +1 −1 ui/effect-drop.js
  6. +2 −2 ui/effect.js
  7. +1 −1 ui/slider.js
  8. +1 −1 ui/widget.js

This file was deleted.

@@ -0,0 +1,9 @@
{
"preset": "jquery",

// disabled until `widget_slice` et al are addressed
"requireCamelCaseOrUpperCaseIdentifiers": null,

// Ref https://github.com/jquery/contribute.jquery.org/issues/80#issuecomment-45253460
"maximumLineLength": null
}
@@ -50,7 +50,7 @@ function submit( commit, runs, configFile, extra, done ) {
}

testswarm.createClient({
url: config.swarmUrl,
url: config.swarmUrl
})
.addReporter( testswarm.reporters.cli )
.auth({
@@ -73,7 +73,7 @@
"grunt-esformatter": "0.2.0",
"grunt-git-authors": "1.2.0",
"grunt-html": "1.0.0",
"grunt-jscs-checker": "0.3.1",
"grunt-jscs": "0.6.2",
"load-grunt-tasks": "0.3.0",
"rimraf": "2.1.4",
"testswarm": "1.1.0"
@@ -42,7 +42,7 @@ return $.effects.effect.drop = function( o, done ) {
el.show();
$.effects.createWrapper( el );

distance = o.distance || el[ ref === "top" ? "outerHeight": "outerWidth" ]( true ) / 2;
distance = o.distance || el[ ref === "top" ? "outerHeight" : "outerWidth" ]( true ) / 2;

if ( show ) {
el
@@ -633,7 +633,7 @@ color.hook = function( hook ) {
}
try {
elem.style[ hook ] = value;
} catch( e ) {
} catch ( e ) {
// wrapped to prevent IE from throwing errors on "invalid" values like 'auto' or 'inherit'
}
}
@@ -998,7 +998,7 @@ $.extend( $.effects, {
// https://bugzilla.mozilla.org/show_bug.cgi?id=561664
try {
active.id;
} catch( e ) {
} catch ( e ) {
active = document.body;
}

@@ -512,7 +512,7 @@ return $.widget( "ui.slider", $.ui.mouse, {
// .slice() creates a copy of the array
// this copy gets trimmed by min and max and then returned
vals = this.options.values.slice();
for ( i = 0; i < vals.length; i+= 1) {
for ( i = 0; i < vals.length; i += 1) {
vals[ i ] = this._trimAlignValue( vals[ i ] );
}

@@ -36,7 +36,7 @@ $.cleanData = (function( orig ) {
}

// http://bugs.jquery.com/ticket/8235
} catch( e ) {}
} catch ( e ) {}
}
orig( elems );
};

0 comments on commit 54004c8

Please sign in to comment.
You can’t perform that action at this time.