Permalink
Browse files

Selectmenu: Fixed event unbinding.

  • Loading branch information...
1 parent 06372cd commit 549b97ed6cc718087ce8b9bff3c8556ab4ca7848 @scottgonzalez scottgonzalez committed Jul 17, 2012
Showing with 8 additions and 6 deletions.
  1. +8 −6 ui/jquery.ui.selectmenu.js
View
14 ui/jquery.ui.selectmenu.js
@@ -108,7 +108,8 @@ $.widget( "ui.selectmenu", {
},
_drawMenu: function() {
- var that = this;
+ var menuInstance,
+ that = this;
// create menu portion, append to body
this.menu = $( '<ul />', {
@@ -126,7 +127,7 @@ $.widget( "ui.selectmenu", {
.appendTo( this.options.appendTo );
// init menu widget
- this.menu.menu({
+ menuInstance = this.menu.menu({
select: function( event, ui ) {
var item = ui.item.data( "item.selectmenu" );
@@ -152,16 +153,17 @@ $.widget( "ui.selectmenu", {
},
// set ARIA role
role: 'listbox'
- });
+ })
+ .data( "ui-menu" );
// change menu styles?
if ( this.options.dropdown ) {
this.menu.addClass( 'ui-corner-bottom' ).removeClass( 'ui-corner-all' );
}
// unbind uneeded Menu events
- this.menu.off( "mouseleave.menu" );
- $( document ).off( "click.menu" );
+ menuInstance._off( this.menu, "mouseleave" );
+ menuInstance._off( this.document, "click" );
},
refresh: function() {
@@ -294,7 +296,7 @@ $.widget( "ui.selectmenu", {
focus: function( event ) {
// init Menu on first focus
this.refresh();
- this.button.off( "focus." + this.widgetName );
+ this._off( this.button, "focus" );
},
click: function( event ) {
this._toggle( event );

0 comments on commit 549b97e

Please sign in to comment.