Skip to content
Permalink
Browse files

datepicker: fixes #4443: Datepicker's vertical position in thickbox. …

…This also fixes the virtual position when the datepicker is close but not right at the bottom of the page.
  • Loading branch information
Ca-Phun Ung
Ca-Phun Ung committed Feb 9, 2010
1 parent b20df98 commit 5eeaa658ba1a37d3ced10a5435a0b302a922c199
Showing with 38 additions and 1 deletion.
  1. +37 −0 tests/visual/datepicker/datepicker_ticket_4443.html
  2. +1 −1 ui/jquery.ui.datepicker.js
@@ -0,0 +1,37 @@
<!doctype html>
<html lang="en">
<head>
<title>Datepicker Visual Test : Datepicker ticket #4443</title>
<link rel="stylesheet" href="../visual.css" type="text/css" />
<link rel="stylesheet" href="../../../themes/base/ui.all.css" type="text/css">
<link rel="stylesheet" href="http://jquery.com/demo/thickbox/thickbox-code/thickbox.css" type="text/css" />
<script type="text/javascript" src="../../../jquery-1.4.1.js"></script>
<script src="http://jquery.com/demo/thickbox/thickbox-code/thickbox-compressed.js"></script>
<script type="text/javascript" src="../../../ui/jquery.ui.core.js"></script>
<script type="text/javascript" src="../../../ui/jquery.ui.widget.js"></script>
<script type="text/javascript" src="../../../ui/jquery.ui.datepicker.js"></script>
<script type="text/javascript">
$(function() {

$('.datepicker').datepicker();

});
</script>
<style type="text/css">
button { display: block; }
</style>
</head>
<body>

<h1 class="ui-widget-header"><a href="http://dev.jqueryui.com/ticket/4443">#4443 - Datepicker's vertical position in thickbox is wrong</a></h1>

<p><input alt="#TB_inline?height=150&width=400&inlineId=myOnPageContent" title="add a caption to title attribute / or leave blank" class="thickbox" type="button" value="Show" /></p>

<div id="myOnPageContent" style="display:none">
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat.</p>
<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. Ut wisi enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit lobortis nisl ut aliquip ex ea commodo consequat.</p>
<input type="text" class="datepicker" />
</div>

</body>
</html>
@@ -725,7 +725,7 @@ $.extend(Datepicker.prototype, {
offset.left -= Math.min(offset.left, (offset.left + dpWidth > viewWidth && viewWidth > dpWidth) ?
Math.abs(offset.left + dpWidth - viewWidth) : 0);
offset.top -= Math.min(offset.top, (offset.top + dpHeight > viewHeight && viewHeight > dpHeight) ?
Math.abs(offset.top + dpHeight + inputHeight * 2 - viewHeight) : 0);
Math.abs(dpHeight + inputHeight) : 0);

return offset;
},

0 comments on commit 5eeaa65

Please sign in to comment.
You can’t perform that action at this time.