Skip to content
Permalink
Browse files

Dialog: Don't focus dialog when mousedown is on close button. Fixes #…

…8838 - Dialog: Close icon does not work in dialog larger than the window in IE.
  • Loading branch information...
jzaefferer committed Nov 26, 2012
1 parent d179cba commit 60486ac632a0a1bbbb0c7449fe17bccfae11af80
Showing with 8 additions and 3 deletions.
  1. +8 −3 ui/jquery.ui.dialog.js
@@ -321,9 +321,14 @@ $.widget("ui.dialog", {
.addClass( "ui-dialog-titlebar ui-widget-header ui-corner-all ui-helper-clearfix" )
.prependTo( this.uiDialog );
this._on( this.uiDialogTitlebar, {
mousedown: function() {
// Dialog isn't getting focus when dragging (#8063)
this.uiDialog.focus();
mousedown: function( event ) {
// Don't prevent click on close button (#8838)
// Focusing a dialog that is partially scrolled out of view
// causes the browser to scroll it into view, preventing the click event
if ( !$( event.target ).closest( ".ui-dialog-titlebar-close" ) ) {
// Dialog isn't getting focus when dragging (#8063)
this.uiDialog.focus();
}
}
});

0 comments on commit 60486ac

Please sign in to comment.
You can’t perform that action at this time.