Skip to content
Permalink
Browse files

Selectmenu: improve id generation

  • Loading branch information...
fnagel committed Apr 29, 2013
1 parent 0264f07 commit 60eed79390def4cbc6ee6e1edf89d749176e8b29
Showing with 7 additions and 3 deletions.
  1. +7 −3 ui/jquery.ui.selectmenu.js
@@ -40,7 +40,11 @@ $.widget( "ui.selectmenu", {

_create: function() {
var selectmenuId = this.element.uniqueId().attr( "id" );
this.ids = { id: selectmenuId, button: selectmenuId + "-button", menu: selectmenuId + "-menu" };
this.ids = {
element: selectmenuId,
button: selectmenuId + "-button",
menu: selectmenuId + "-menu"
};

this._drawButton();
this._drawMenu();
@@ -56,7 +60,7 @@ $.widget( "ui.selectmenu", {
var tabindex = this.element.attr( "tabindex" );

// fix existing label
this.label = $( "label[for='" + this.ids.id + "']" ).attr( "for", this.ids.button );
this.label = $( "label[for='" + this.ids.element + "']" ).attr( "for", this.ids.button );
this._on( this.label, {
"click": function( event ) {
this.button.focus();
@@ -461,7 +465,7 @@ $.widget( "ui.selectmenu", {
this.button.remove();
this.element.show();
this.element.removeUniqueId();
this.label.attr( "for", this.ids.id );
this.label.attr( "for", this.ids.element );
}
});

0 comments on commit 60eed79

Please sign in to comment.
You can’t perform that action at this time.