Skip to content
Permalink
Browse files

Autocomplete: Avoid handling keypress when keydown modified the searc…

…h term. Fixes #7799 - Autocomplete regression - Cannot type '&' in IE and Chrome.
  • Loading branch information...
scottgonzalez committed Oct 17, 2011
1 parent d4d8d74 commit 63374dcb520f5ad7104ccb57b8eb01dca4087889
Showing with 14 additions and 0 deletions.
  1. +14 −0 ui/jquery.ui.autocomplete.js
@@ -48,7 +48,15 @@ $.widget( "ui.autocomplete", {
_create: function() {
var self = this,
doc = this.element[ 0 ].ownerDocument,
// Some browsers only repeat keydown events, not keypress events,
// so we use the suppressKeyPress flag to determine if we've already
// handled the keydown event. #7269
// Unfortunately the code for & in keypress is the same as the up arrow,
// so we use the suppressKeyPressRepeat flag to avoid handling keypress
// events when we know the keydown event was used to modify the
// search term. #7799
suppressKeyPress,
suppressKeyPressRepeat,
suppressInput;

this.valueMethod = this.element[ this.element.is( "input,textarea" ) ? "val" : "text" ];
@@ -66,11 +74,13 @@ $.widget( "ui.autocomplete", {
if ( self.options.disabled || self.element.prop( "readOnly" ) ) {
suppressKeyPress = true;
suppressInput = true;
suppressKeyPressRepeat = true;
return;
}

suppressKeyPress = false;
suppressInput = false;
suppressKeyPressRepeat = false;
var keyCode = $.ui.keyCode;
switch( event.keyCode ) {
case keyCode.PAGE_UP:
@@ -116,6 +126,7 @@ $.widget( "ui.autocomplete", {
}
break;
default:
suppressKeyPressRepeat = true;
// search timeout should be triggered before the input value is changed
self._searchTimeout( event );
break;
@@ -127,6 +138,9 @@ $.widget( "ui.autocomplete", {
event.preventDefault();
return;
}
if ( suppressKeyPressRepeat ) {
return;
}

// replicate some key handlers to allow them to repeat in Firefox and Opera
var keyCode = $.ui.keyCode;

1 comment on commit 63374dc

@jzaefferer

This comment has been minimized.

Copy link
Member

commented on 63374dc Oct 17, 2011

ugh

Please sign in to comment.
You can’t perform that action at this time.