Skip to content
Permalink
Browse files

Spinner: Fixed double firing of change event when setting the value o…

…ption directly.
  • Loading branch information
scottgonzalez committed Aug 7, 2011
1 parent 6c9dac2 commit 6c84531d7ced59fc3b884aa11845c7016d4187aa
Showing with 8 additions and 10 deletions.
  1. +6 −1 demos/spinner/default.html
  2. +2 −9 ui/jquery.ui.spinner.js
@@ -6,14 +6,19 @@
<link type="text/css" href="../../themes/base/jquery.ui.all.css" rel="stylesheet" />
<script type="text/javascript" src="../../jquery-1.6.2.js"></script>
<script type="text/javascript" src="../../external/jquery.mousewheel-3.0.4.js"></script>
<script type="text/javascript" src="../../external/jquery.global.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.core.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.widget.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.button.js"></script>
<script type="text/javascript" src="../../ui/jquery.ui.spinner.js"></script>
<link type="text/css" href="../demos.css" rel="stylesheet" />
<script type="text/javascript">
$(function() {
$("#spinner").spinner();
$("#spinner").spinner({
change: function() {
console.log( "change" );
}
});
$("#disable").toggle(function() {
$("#spinner").spinner("disable");
@@ -287,7 +287,7 @@ $.widget( "ui.spinner", {

_setOption: function( key, value ) {
if ( key === "value" ) {
return this._setOptionValue( value );
return this._value( value );
}

this._super( "_setOption", key, value );
@@ -303,14 +303,6 @@ $.widget( "ui.spinner", {
}
},

_setOptionValue: function( value ) {
var previous = this.options.value;
this._value( value );
if ( previous !== this.options.value ) {
this._trigger( "change" );
}
},

_setOptions: modifier(function( options ) {
this._super( "_setOptions", options );

@@ -342,6 +334,7 @@ $.widget( "ui.spinner", {
_value: function( value ) {
this.options.value = this._trimValue( this._parse(value) );
this._format();
this._aria();
},

destroy: function() {

0 comments on commit 6c84531

Please sign in to comment.
You can’t perform that action at this time.